BUG: SqlDataReader does not propagate deadlock exceptions in SqlClient (316667)

MORE INFORMATION

Steps to Reproduce the Behavior

1. Open a new Microsoft Visual C# .NET console project.
2. Delete all of the code inside the code window.
3. Paste the following code inside the module:

   using System;
   using System.Threading;
   using System.Data;
   using System.Data.SqlClient;
   using System.Diagnostics;
   class MainThread
   {
       [STAThread]
       public static void Main(string[] args)
       {
           Debug.WriteLine( "Creating table." );
           String connectionString = "Data Source=localhost;Integrated Security=SSPI;Initial Catalog=master";
           SqlConnection c = new SqlConnection(connectionString);
           c.Open();
           CreateTable( c );
           c.Close();
   
           // Start clean.
           SqlConnection c1 = new SqlConnection(connectionString);
           SqlConnection c2 = new SqlConnection(connectionString);
   
           c1.Open();
           c2.Open();
   
           SqlTransaction t1 = c1.BeginTransaction( System.Data.IsolationLevel.RepeatableRead );
           SqlTransaction t2 = c2.BeginTransaction( System.Data.IsolationLevel.RepeatableRead );
   		Debug.WriteLine( "Starting test." );
   
           ReadStuff( "select * from dmvasitest where a = 1", c1, t1 );
           WriteStuff( "update dmvasitest set b = 2 where a = 2", c2, t2 );
           SecondThread.Run( "select * from dmvasitest where a = 2", c1, t1 );
           Debug.WriteLine( "-- PLEASE NOTE THAT PREV STATEMENT IS BLOCKED NOW. NEXT STATEMENT WILL CAUSE DEADLOCK" );
           WriteStuff( "update dmvasitest set b = 1 where a = 1", c2, t2 );
   
           c1.Close();
           c2.Close();
           Debug.WriteLine( "Test done." );
       }
   
       public static void CreateTable( SqlConnection c )
       {
           // Create new table.
           String text1 = @"
   if exists (select * from dbo.sysobjects where id = object_id(N'[dbo].[dmvasitest]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
   drop table [dbo].[dmvasitest]
   ";
           String text2 = @"
   create table dmvasitest (
      a int,
      b int
   )
   ";
           String text3 = @"
   insert into dmvasitest (a,b) values (1,1)
   insert into dmvasitest (a,b) values (2,2)
   ";
   
           SqlCommand cmd1 = new SqlCommand( text1, c );
           cmd1.ExecuteNonQuery();
           SqlCommand cmd2 = new SqlCommand( text2, c );
           cmd2.ExecuteNonQuery();
           SqlCommand cmd3 = new SqlCommand( text3, c );
           cmd3.ExecuteNonQuery();
       }
   
       public static void ReadStuff( String text, SqlConnection c, SqlTransaction t ) 
       {
           Debug.WriteLine( "Reading: '{0}'", text );
           SqlCommand command = new SqlCommand( text, c, t );
           SqlDataReader reader = command.ExecuteReader();
           try
           {
               while (reader.Read())
               {
                   int a = reader.GetInt32(0);
                   int b = reader.GetInt32(1);
               }
               Debug.WriteLine( "All data has been read. -- FIRST TIME OK, BUT YOU SHOULD NOT SEE THIS FOR THE SECOND TIME!!!" );
   			// Uncomment following line to see the correct error.
   			// reader.NextResult();
           }
           catch(Exception e)
           {
               Debug.WriteLine( "Exception thrown: {0}", e.ToString() );
           }
           finally
           {
               reader.Close();
           }
       }
   
       public static void WriteStuff( String text, SqlConnection c, SqlTransaction t )
       {
           Debug.WriteLine( "Writing: '{0}'", text );
           SqlCommand command = new SqlCommand( text, c, t );
           try 
           {
               command.ExecuteNonQuery();
               Debug.WriteLine( "Data written." );
           }
           catch(Exception e)
           {
               Debug.WriteLine( "Exception thrown: {0}", e.ToString() );
           }
       }
   }
   
   class SecondThread
   {
       String m_text;
       SqlConnection m_connection;
       SqlTransaction m_transaction;
       public SecondThread( String text, SqlConnection connection, SqlTransaction transaction )
       {
           m_text = text;
           m_connection = connection;
           m_transaction = transaction;
       }
       private void Run()
       {
           MainThread.ReadStuff( m_text, m_connection, m_transaction );
       }
   
       public static void Run( String text, SqlConnection connection, SqlTransaction transaction )
       {
           SecondThread secondThread = new SecondThread( text, connection, transaction );
           Thread thread = new Thread( new ThreadStart( secondThread.Run ) );
           thread.Start();
           Thread.Sleep(300);
       }
   
   }
   					

4. Press F5 to run the application.
5. On the View menu, click Other Windows, then click Output to view the result.
   
   You receive a random error similar to the error described in the "Symptoms" section of this article.
6. Edit the code and uncomment the following line:

   // reader.NextResult();
   					

7. Press F5 to run the application.
8. On the View menu, click Other Windows, then click Output to view the result.
   
   This time you receive the expected results indicating the actual problem.